Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some docstrings #1053

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix some docstrings #1053

merged 2 commits into from
Sep 20, 2024

Conversation

stavros11
Copy link
Member

While checking for ExecutionParameters, I found various leftovers, mainly in docstrings, which should have been updated to the new public API (and _core structure).

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (c0a2e42) to head (49133dc).
Report is 14 commits behind head on 0.2.

Additional details and impacted files
@@           Coverage Diff           @@
##              0.2    #1053   +/-   ##
=======================================
  Coverage   52.08%   52.08%           
=======================================
  Files          63       63           
  Lines        2803     2803           
=======================================
  Hits         1460     1460           
  Misses       1343     1343           
Flag Coverage Δ
unittests 52.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from private-execution-parameters to 0.2 September 19, 2024 22:55
@alecandido alecandido added this to the Qibolab 0.2.0 milestone Sep 19, 2024
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've been quite negligent with docs and docstrings, so this is a clear improvement.

I expect even some further leftover, but we will incrementally improve tests and docs in future 0.2.x releases.

src/qibolab/_core/pulses/pulse.py Show resolved Hide resolved
doc/source/tutorials/instrument.rst Show resolved Hide resolved
@stavros11 stavros11 merged commit d51abf2 into 0.2 Sep 20, 2024
28 checks passed
@stavros11 stavros11 deleted the fix-docstrings branch September 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants